Fixing CVE-2022-42731 for v2.5

.gitignore

@@ -104,4 +104,3 @@ venv.bak/
 
 # mypy
 .mypy_cache/
-example/test_db

CHANGELOG.md

@@ -1,30 +1,6 @@
 # Change Log
-## 3.0 (Unreleased)
-* Updated to fido2==1.1.0
-* Removed: CBOR and exchange is done in JSON now
-* Added: the following settings 
-  * `MFA_FIDO2_RESIDENT_KEY`: Defaults to `Discouraged` which was the old behaviour
-  * `MFA_FIDO2_AUTHENTICATOR_ATTACHMENT`: If you like to have a PLATFORM Authenticator, Defaults to NONE
-  * `MFA_FIDO2_USER_VERIFICATION`:  If you need User Verification 
-  * `MFA_FIDO2_ATTESTATION_PREFERENCE`: If you like to have an Attention
-* Added: ConditionalUI support (check example)
-
-## 2.6.1
-* Fix: CVE-2022-42731: related to the possibility of registration replay attack.
-  Thanks to 'SSE (Secure Systems Engineering)'
-
-## 2.5.1
-* Fix: CVE-2022-42731: related to the possibility of registration replay attack.
-  Thanks to 'SSE (Secure Systems Engineering)' 
-
-## 2.6.0
-   * Adding Backup Recovery Codes (Recovery) as a method.
-     Thanks to @Spitfireap for work, and  @peterthomassen for guidance.
-   * Added: `RECOVERY_ITERATION` to set the number of iteration when hashing recovery token
-   * Added: `MFA_ENFORCE_RECOVERY_METHOD` to enforce the user to enroll in the recovery code method once, they add any other method,
-   * Added: `MFA_ALWAYS_GO_TO_LAST_METHOD` to the settings which redirects the user automatically to the last used method when logging in
-   * Added: `MFA_RENAME_METHODS` to be able to rename the methods for the user.
-   * Fix: Alot of CSS fixes for the example application
+## 2.5.2
+* Fix: CVE-2022-42731: related to possibility of registration replay attack thanks to 'SSE (Secure Systems Engineering)' 
    
 ## 2.5.0
 

EXAMPLE.md

@@ -4,15 +4,5 @@
 `virtualenv venv`
 1. activate env `source venv/bin/activate`
 1. install requirements `pip install -r requirements.txt`
-1. cd to example project `cd example`
 1. migrate `python manage.py migrate`
-1. create super user `python manage.py createsuperuser`
-1. start the server `python manage.py runserver`
-
-# Notes for SSL
-
-To test FIDO2 you need to use HTTPS, after the above steps are done:
-
-1. stop the server
-1. install requirements `pip install -r example-ssl-requirements.txt`
-1. start the ssl server `python manage.py runsslserver`
+1. create super user 'python manage.py createsuperuser' 

README.md

@@ -1,7 +1,6 @@
 # django-mfa2
-A Django app that handles MFA, it supports TOTP, U2F, FIDO2 U2F (Web Authn), Email Tokens , Trusted  Devices and backup codes.
+A Django app that handles MFA, it supports TOTP, U2F, FIDO2 U2F (Web Authn), Email Tokens , and Trusted Devices
 
-[![Works with PassKeys](https://github.com/mkalioby/django-mfa2/raw/master/img/Works%20with%20PassKeys-black.png)](https://fidoalliance.org/passkeys/)
 ### Pip Stats
 [![PyPI version](https://badge.fury.io/py/django-mfa2.svg)](https://badge.fury.io/py/django-mfa2)
 [![Downloads Count](https://static.pepy.tech/personalized-badge/django-mfa2?period=total&units=international_system&left_color=black&right_color=green&left_text=Downloads)](https://pepy.tech/project/django-mfa2)
@@ -17,7 +16,7 @@ Web Authencation API (WebAuthn) is state-of-the art techology that is expected t
 
 For FIDO2, the following are supported
  * **security keys** (Firefox 60+, Chrome 67+, Edge 18+, Safari 13 on Mac OS, Chrome on Andriod, Safari on iOS 13.3+),
- * **Windows Hello** (Firefox 67+, Chrome 72+ , Edge),
+ * **Windows Hello** (Firefox 67+, Chrome 72+ , Edge) ,
  * **Apple's Touch ID/Face ID** (Chrome 70+ on Mac OS X, Safari on macOS Big Sur, Safari on iOS 14.0+ ),
  * **android-safetynet** (Chrome 70+, Firefox 68+)
  * **NFC devices using PCSC** (Not Tested, but as supported in fido2)
@@ -68,8 +67,7 @@ Depends on
 3. Add the following settings to your file
 
    ```python 
-   from django.conf.global_settings import PASSWORD_HASHERS as DEFAULT_PASSWORD_HASHERS #Preferably at the same place where you import your other modules
-   MFA_UNALLOWED_METHODS=()   # Methods that shouldn't be allowed for the user e.g ('TOTP','U2F',)
+   MFA_UNALLOWED_METHODS=()   # Methods that shouldn't be allowed for the user
    MFA_LOGIN_CALLBACK=""      # A function that should be called by username to login the user in session
    MFA_RECHECK=True           # Allow random rechecking of the user
    MFA_REDIRECT_AFTER_REGISTRATION="mfa_home"   # Allows Changing the page after successful registeration
@@ -77,23 +75,15 @@ Depends on
    MFA_RECHECK_MIN=10         # Minimum interval in seconds
    MFA_RECHECK_MAX=30         # Maximum in seconds
    MFA_QUICKLOGIN=True        # Allow quick login for returning users by provide only their 2FA
-   MFA_ALWAYS_GO_TO_LAST_METHOD = False # Always redirect the user to the last method used to save a click (Added in 2.6.0).
-   MFA_RENAME_METHODS={} #Rename the methods in a more user-friendly way e.g {"RECOVERY":"Backup Codes"} (Added in 2.6.0)
    MFA_HIDE_DISABLE=('FIDO2',)     # Can the user disable his key (Added in 1.2.0).
    MFA_OWNED_BY_ENTERPRISE = FALSE  # Who owns security keys   
-   PASSWORD_HASHERS = DEFAULT_PASSWORD_HASHERS # Comment if PASSWORD_HASHER already set in your settings.py
-   PASSWORD_HASHERS += ['mfa.recovery.Hash'] 
-   RECOVERY_ITERATION = 350000 #Number of iteration for recovery code, higher is more secure, but uses more resources for generation and check...
 
    TOKEN_ISSUER_NAME="PROJECT_NAME"      #TOTP Issuer name
 
    U2F_APPID="https://localhost"    #URL For U2F
-   FIDO_SERVER_ID=u"localehost"      # Server rp id for FIDO2, it is the full domain of your project
+   FIDO_SERVER_ID=u"localehost"      # Server rp id for FIDO2, it the full domain of your project
    FIDO_SERVER_NAME=u"PROJECT_NAME"
-   MFA_FIDO2_RESIDENT_KEY = mfa.ResidentKey.DISCOURAGED  # Resident Key allows a special User Handle
-   MFA_FIDO2_AUTHENTICATOR_ATTACHMENT = None  # Let the user choose
-   MFA_FIDO2_USER_VERIFICATION = None         # Verify User Presence
-   MFA_FIDO2_ATTESTATION_PREFERENCE = mfa.AttestationPreference.NONE
+   FIDO_LOGIN_URL=BASE_URL
    ```
    **Method Names**
    * U2F
@@ -101,17 +91,12 @@ Depends on
    * TOTP
    * Trusted_Devices
    * Email
-   * RECOVERY
    
    **Notes**:
     * Starting version 1.1, ~~FIDO_LOGIN_URL~~ isn't required for FIDO2 anymore.
     * Starting version 1.7.0, Key owners can be specified.
     * Starting version 2.2.0
         * Added: `MFA_SUCCESS_REGISTRATION_MSG` & `MFA_REDIRECT_AFTER_REGISTRATION`
-    * Starting version 2.6.0
-        * Added: `MFA_ALWAYS_GO_TO_LAST_METHOD`, `MFA_RENAME_METHODS`, `MFA_ENFORCE_RECOVERY_METHOD` & `RECOVERY_ITERATION`
-    * Starting version 3.0
-        * Added: `MFA_FIDO2_RESIDENT_KEY`, `MFA_FIDO2_AUTHENTICATOR_ATTACHMENT`, `MFA_FIDO2_USER_VERIFICATION`, `MFA_FIDO2_ATTESTATION_PREFERENCE`
 4. Break your login function
 
    Usually your login function will check for username and password, log the user in if the username and password are correct and create the user session, to support mfa, this has to change
@@ -151,7 +136,7 @@ Depends on
 ```<li><a href="{% url 'mfa_home' %}">Security</a> </li>```
 
 
-For Example, See 'example' app and look at EXAMPLE.md to see how to set it up.
+For Example, See 'example' app
 
 # Going Passwordless
 
@@ -203,8 +188,6 @@ function some_func() {
 * [AndreasDickow](https://github.com/AndreasDickow)
 * [mnelson4](https://github.com/mnelson4)
 * [ezrajrice](https://github.com/ezrajrice)
-* [Spitfireap](https://github.com/Spitfireap)
-* [peterthomassen](https://github.com/peterthomassen)
 
 
  # Security contact information

example/example-ssl-requirements.txt

@@ -1 +0,0 @@
-django-sslserver

example/example/settings.py

@@ -11,9 +11,6 @@ https://docs.djangoproject.com/en/2.0/ref/settings/
 """
 
 import os
-from django.conf.global_settings import PASSWORD_HASHERS as DEFAULT_PASSWORD_HASHERS
-
-import mfa
 
 # Build paths inside the project like this: os.path.join(BASE_DIR, ...)
 BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
@@ -145,18 +142,9 @@ MFA_QUICKLOGIN=True        # Allow quick login for returning users by provide on
 MFA_HIDE_DISABLE=('',)     # Can the user disable his key (Added in 1.2.0).
 MFA_REDIRECT_AFTER_REGISTRATION="registered"
 MFA_SUCCESS_REGISTRATION_MSG="Go to Home"
-MFA_ALWAYS_GO_TO_LAST_METHOD = True
-MFA_ENFORCE_RECOVERY_METHOD = True
-MFA_FIDO2_RESIDENT_KEY = mfa.ResidentKey.REQUIRED  # Resident Key allows a special User Handle
-MFA_FIDO2_AUTHENTICATOR_ATTACHMENT = None  # Let the user choose
-MFA_FIDO2_USER_VERIFICATION = None         # Verify User Presence
-MFA_FIDO2_ATTESTATION_PREFERENCE = mfa.AttestationPreference.NONE
-MFA_RENAME_METHODS = {"RECOVERY":"Backup Codes","FIDO2":"Biometric Authentication"}
-PASSWORD_HASHERS = DEFAULT_PASSWORD_HASHERS #Comment if PASSWORD_HASHER already set
-PASSWORD_HASHERS += ['mfa.recovery.Hash']
-RECOVERY_ITERATION = 1 #Number of iteration for recovery code, higher is more secure, but uses more resources for generation and check...
+
 TOKEN_ISSUER_NAME="PROJECT_NAME"      #TOTP Issuer name
 
-U2F_APPID="https://localhost:9000"    #URL For U2F
+U2F_APPID="https://localhost"    #URL For U2F
 FIDO_SERVER_ID="localhost"      # Server rp id for FIDO2, it the full domain of your project
 FIDO_SERVER_NAME="TestApp"

example/example/templates/base.html

@@ -10,7 +10,7 @@
   <meta name="description" content="">
   <meta name="author" content="">
 
-  <title>Django-mfa2 Example</title>
+  <title>SB Admin - Blank Page</title>
 
   <!-- Custom fonts for this template-->
   <link href="{% static 'vendor/fontawesome-free/css/all.min.css'%}" rel="stylesheet" type="text/css">

example/example/templates/login.html

@@ -44,9 +44,7 @@
             </div>
           </div>
 
-          <button class="btn btn-primary btn-block" type="submit">Login</button><br/>
-
-            <button class="btn btn-primary btn-block" type="button" onclick="authen()">Login By Security Key</button>
+          <button class="btn btn-primary btn-block" type="submit">Login</button>
         </form>
       </div>
     </div>
@@ -58,7 +56,7 @@
 
   <!-- Core plugin JavaScript-->
   <script src="{% static 'vendor/jquery-easing/jquery.easing.min.js'%}"></script>
-    {% include 'FIDO2/Auth_JS.html'%}
+
 </body>
 
 </html>

example/requiremnts.txt

@@ -0,0 +1,2 @@
+django >= 2.2
+django_ssl

mfa/Email.py

@@ -34,16 +34,10 @@ def start(request):
                 from django.core.urlresolvers import reverse
             except:
                 from django.urls import reverse
-            if getattr(settings, 'MFA_ENFORCE_RECOVERY_METHOD', False) and not User_Keys.objects.filter(
-                    key_type="RECOVERY", username=request.user.username).exists():
-                request.session["mfa_reg"] = {"method": "Email",
-                                              "name": getattr(settings, "MFA_RENAME_METHODS", {}).get("Email", "Email")}
-            else:
             return HttpResponseRedirect(reverse(getattr(settings,'MFA_REDIRECT_AFTER_REGISTRATION','mfa_home')))
         context["invalid"] = True
     else:
         request.session["email_secret"] = str(randint(0,100000))  #generate a random integer
-
         if sendEmail(request, request.user.username, request.session["email_secret"]):
             context["sent"] = True
     return render(request,"Email/Add.html", context)

mfa/FIDO2.py

@@ -1,6 +1,6 @@
 from fido2.client import Fido2Client
 from fido2.server import Fido2Server, PublicKeyCredentialRpEntity
-from fido2.webauthn import AttestationObject, AuthenticatorData, CollectedClientData, RegistrationResponse
+from fido2.webauthn import AttestationObject, AuthenticatorData, CollectedClientData
 from django.template.context_processors import csrf
 from django.views.decorators.csrf import csrf_exempt
 from django.shortcuts import render
@@ -16,14 +16,8 @@ from .views import login, reset_cookie
 import datetime
 from .Common import get_redirect_url
 from django.utils import timezone
-import fido2.features
 from django.http import JsonResponse
 
-def enable_json_mapping():
-    try:
-        fido2.features.webauthn_json_mapping.enabled = True
-    except:
-        pass
 def recheck(request):
     """Starts FIDO2 recheck"""
     context = csrf(request)
@@ -34,59 +28,46 @@ def recheck(request):
 
 def getServer():
     """Get Server Info from settings and returns a Fido2Server"""
-    from mfa import AttestationPreference
     rp = PublicKeyCredentialRpEntity(id=settings.FIDO_SERVER_ID, name=settings.FIDO_SERVER_NAME)
-    attestation= getattr(settings,'MFA_FIDO2_ATTESTATION_PREFERENCE', AttestationPreference.NONE )
-    return Fido2Server(rp,attestation=attestation)
+    return Fido2Server(rp)
 
 
 def begin_registeration(request):
     """Starts registering a new FIDO Device, called from API"""
-    enable_json_mapping()
     server = getServer()
-    from mfa import ResidentKey
-    resident_key = getattr(settings,'MFA_FIDO2_RESIDENT_KEY', ResidentKey.DISCOURAGED)
-    auth_attachment = getattr(settings,'MFA_FIDO2_AUTHENTICATOR_ATTACHMENT', None)
-    user_verification = getattr(settings,'MFA_FIDO2_USER_VERIFICATION', None)
     registration_data, state = server.register_begin({
         u'id': request.user.username.encode("utf8"),
-        u'name': request.user.username,
+        u'name': (request.user.first_name + " " + request.user.last_name),
         u'displayName': request.user.username,
-    }, getUserCredentials(request.user.username),user_verification = user_verification,
-        resident_key_requirement = resident_key, authenticator_attachment = auth_attachment)
-    request.session['fido2_state'] = state
-    return JsonResponse(dict(registration_data))
-    #return HttpResponse(cbor.encode(registration_data), content_type = 'application/octet-stream')
+    }, getUserCredentials(request.user.username))
+    request.session['fido_state'] = state
+
+    return HttpResponse(cbor.encode(registration_data), content_type = 'application/octet-stream')
 
 
 @csrf_exempt
 def complete_reg(request):
     """Completes the registeration, called by API"""
     try:
-        if not "fido2_state" in request.session:
+        if not "fido_state" in request.session:
             return JsonResponse({'status': 'ERR', "message": "FIDO Status can't be found, please try again"})
-        enable_json_mapping()
-        data = simplejson.loads(request.body)
-        server = getServer()
-        auth_data = server.register_complete(request.session["fido2_state"], response = data)
-        registration = RegistrationResponse.from_dict(data)
-        attestation_object = registration.response.attestation_object
-        #auth_data = attestation_object.auth_data
-        att_obj = attestation_object
+        data = cbor.decode(request.body)
 
+        client_data = CollectedClientData(data['clientDataJSON'])
+        att_obj = AttestationObject((data['attestationObject']))
+        server = getServer()
+        auth_data = server.register_complete(
+            request.session.pop('fido_state'),
+            client_data,
+            att_obj
+        )
         encoded = websafe_encode(auth_data.credential_data)
         uk = User_Keys()
         uk.username = request.user.username
         uk.properties = {"device": encoded, "type": att_obj.fmt, }
         uk.owned_by_enterprise = getattr(settings, "MFA_OWNED_BY_ENTERPRISE", False)
         uk.key_type = "FIDO2"
-        if auth_data.credential_data.credential_id:
-            uk.user_handle = auth_data.credential_data.credential_id
         uk.save()
-        if getattr(settings, 'MFA_ENFORCE_RECOVERY_METHOD', False) and not User_Keys.objects.filter(key_type = "RECOVERY", username=request.user.username).exists():
-            request.session["mfa_reg"] = {"method":"FIDO2","name": getattr(settings, "MFA_RENAME_METHODS", {}).get("FIDO2", "FIDO2")}
-            return HttpResponse(simplejson.dumps({'status': 'RECOVERY'}))
-        else:
         return HttpResponse(simplejson.dumps({'status': 'OK'}))
     except Exception as exp:
         import traceback
@@ -100,16 +81,17 @@ def complete_reg(request):
 
 
 def start(request):
-    """Start Registration a new FIDO Token"""
+    """Start Registeration a new FIDO Token"""
     context = csrf(request)
     context.update(get_redirect_url())
-    context["method"] = {"name":getattr(settings,"MFA_RENAME_METHODS",{}).get("FIDO2","FIDO2 Security Key")}
-    context["RECOVERY_METHOD"]=getattr(settings,"MFA_RENAME_METHODS",{}).get("RECOVERY","Recovery codes")
     return render(request, "FIDO2/Add.html", context)
 
 
 def getUserCredentials(username):
-    return [AttestedCredentialData(websafe_decode(uk.properties["device"])) for uk in User_Keys.objects.filter(username = username, key_type = "FIDO2")]
+    credentials = []
+    for uk in User_Keys.objects.filter(username = username, key_type = "FIDO2"):
+        credentials.append(AttestedCredentialData(websafe_decode(uk.properties["device"])))
+    return credentials
 
 
 def auth(request):
@@ -118,55 +100,33 @@ def auth(request):
 
 
 def authenticate_begin(request):
-    enable_json_mapping()
     server = getServer()
-    credentials=[]
-    username = None
-    if "base_username" in request.session:
-        username = request.session["base_username"]
-    if request.user.is_authenticated:
-        username = request.user.username
-    if username:
     credentials = getUserCredentials(request.session.get("base_username", request.user.username))
     auth_data, state = server.authenticate_begin(credentials)
-    request.session['fido2_state'] = state
-    return JsonResponse(dict(auth_data))
+    request.session['fido_state'] = state
+    return HttpResponse(cbor.encode(auth_data), content_type = "application/octet-stream")
 
 
 @csrf_exempt
 def authenticate_complete(request):
     try:
-        enable_json_mapping()
         credentials = []
-        username = None
-        keys = None
-        if "base_username" in request.session:
-            username = request.session["base_username"]
-        if request.user.is_authenticated:
-            username = request.user.username
+        username = request.session.get("base_username", request.user.username)
         server = getServer()
-        data = simplejson.loads(request.body)
-        userHandle = data.get("response",{}).get('userHandle')
-        credential_id = data['id']
-
-        if userHandle:
-            if User_Keys.objects.filter(username=userHandle).exists():
-                credentials = getUserCredentials(userHandle)
-                username=userHandle
-            else:
-                keys = User_Keys.objects.filter(user_handle = userHandle)
-                if keys.exists():
-                    credentials = [AttestedCredentialData(websafe_decode(keys[0].properties["device"]))]
-        elif credential_id and username is None:
-            keys = User_Keys.objects.filter(user_handle = credential_id)
-            if keys.exists():
-                credentials=[AttestedCredentialData(websafe_decode(keys[0].properties["device"]))]
-        else:
         credentials = getUserCredentials(username)
-
+        data = cbor.decode(request.body)
+        credential_id = data['credentialId']
+        client_data = CollectedClientData(data['clientDataJSON'])
+        auth_data = AuthenticatorData(data['authenticatorData'])
+        signature = data['signature']
         try:
             cred = server.authenticate_complete(
-                    request.session.pop('fido2_state'), credentials = credentials, response = data
+                request.session.pop('fido_state'),
+                credentials,
+                credential_id,
+                client_data,
+                auth_data,
+                signature
             )
         except ValueError:
             return HttpResponse(simplejson.dumps({'status': "ERR",
@@ -179,7 +139,7 @@ def authenticate_complete(request):
             except:
                 pass
             return HttpResponse(simplejson.dumps({'status': "ERR",
-                                                  "message": str(excep)}),
+                                                  "message": excep.message}),
                                 content_type = "application/json")
 
         if request.session.get("mfa_recheck", False):
@@ -189,7 +149,6 @@ def authenticate_complete(request):
                                 content_type = "application/json")
         else:
             import random
-            if keys is None:
             keys = User_Keys.objects.filter(username = username, key_type = "FIDO2", enabled = 1)
             for k in keys:
                 if AttestedCredentialData(websafe_decode(k.properties["device"])).credential_id == cred.credential_id:
@@ -205,7 +164,7 @@ def authenticate_complete(request):
                     except:
                         authenticated = request.user.is_authenticated()
                     if not authenticated:
-                        res = login(request,k.username)
+                        res = login(request)
                         if not "location" in res: return reset_cookie(request)
                         return HttpResponse(simplejson.dumps({'status': "OK", "redirect": res["location"]}),
                                             content_type = "application/json")

mfa/U2F.py

@@ -52,8 +52,8 @@ def validate(request,username):
 
     challenge = request.session.pop('_u2f_challenge_')
     device, c, t = complete_authentication(challenge, data, [settings.U2F_APPID])
-    try:
-        key=User_Keys.objects.get(username=username,properties__icontains='"publicKey": "%s"'%device["publicKey"])
+
+    key=User_Keys.objects.get(username=username,properties__shas="$.device.publicKey=%s"%device["publicKey"])
     key.last_used=timezone.now()
     key.save()
     mfa = {"verified": True, "method": "U2F","id":key.id}
@@ -63,18 +63,14 @@ def validate(request,username):
                     seconds=random.randint(settings.MFA_RECHECK_MIN, settings.MFA_RECHECK_MAX))))
     request.session["mfa"] = mfa
     return True
-    except:
-        return False
-
-
 
 def auth(request):
     context=csrf(request)
     s=sign(request.session["base_username"])
     request.session["_u2f_challenge_"]=s[0]
     context["token"]=s[1]
-    context["method"] = {"name": getattr(settings, "MFA_RENAME_METHODS", {}).get("U2F", "Classical Security Key")}
-    return render(request,"U2F/Auth.html",context)
+
+    return render(request,"U2F/Auth.html")
 
 def start(request):
     enroll = begin_registration(settings.U2F_APPID, [])
@@ -82,8 +78,6 @@ def start(request):
     context=csrf(request)
     context["token"]=simplejson.dumps(enroll.data_for_client)
     context.update(get_redirect_url())
-    context["method"] = {"name": getattr(settings, "MFA_RENAME_METHODS", {}).get("U2F", "Classical Security Key")}
-    context["RECOVERY_METHOD"] = getattr(settings, "MFA_RENAME_METHODS", {}).get("RECOVERY", "Recovery codes")
     return render(request,"U2F/Add.html",context)
 
 
@@ -104,11 +98,6 @@ def bind(request):
     uk.properties = {"device":simplejson.loads(device.json),"cert":cert_hash}
     uk.key_type = "U2F"
     uk.save()
-    if getattr(settings, 'MFA_ENFORCE_RECOVERY_METHOD', False) and not User_Keys.objects.filter(key_type="RECOVERY",
-                                                                                                username=request.user.username).exists():
-        request.session["mfa_reg"] = {"method": "U2F",
-                                      "name": getattr(settings, "MFA_RENAME_METHODS", {}).get("U2F", "Classical Security Key")}
-        return HttpResponse('RECOVERY')
     return HttpResponse("OK")
 
 def sign(username):

mfa/__init__.py

@@ -1,5 +1 @@
-__version__="2.7.1"
-from fido2.webauthn import ResidentKeyRequirement as ResidentKey
-from fido2.webauthn import AuthenticatorAttachment as Attachment
-from fido2.webauthn import UserVerificationRequirement as UserVerification
-from fido2.webauthn import AttestationConveyancePreference as AttestationPreference
+__version__="2.2.0"

mfa/migrations/0012_user_keys_userhandle.py

@@ -1,17 +0,0 @@
-# Generated by Django 2.2 on 2022-10-16 14:15
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('mfa', '0011_auto_20210530_0622'),
-    ]
-    operations = [
-        migrations.AddField(
-            model_name='user_keys',
-            name='user_handle',
-            field=models.CharField(blank=True, default=None, max_length=255, null=True),
-        ),
-    ]

mfa/models.py

@@ -16,7 +16,6 @@ class User_Keys(models.Model):
     expires=models.DateTimeField(null=True,default=None,blank=True)
     last_used=models.DateTimeField(null=True,default=None,blank=True)
     owned_by_enterprise=models.BooleanField(default=None,null=True,blank=True)
-    user_handle = models.CharField(default = None, null = True, blank = True, max_length = 255)
 
     def save(self, force_insert=False, force_update=False, using=None, update_fields=None):
         if self.key_type == "Trusted Device" and self.properties.get("signature","") == "":

mfa/recovery.py

@@ -1,122 +0,0 @@
-from django.shortcuts import render
-from django.views.decorators.cache import never_cache
-from django.template.context_processors import csrf
-from django.contrib.auth.hashers import make_password, PBKDF2PasswordHasher
-from django.http import HttpResponse
-from .Common import get_redirect_url
-from .models import *
-import simplejson
-import random
-import string
-import datetime
-from django.utils import timezone
-
-USER_FRIENDLY_NAME = "Recovery Codes"
-
-class Hash(PBKDF2PasswordHasher):
-    algorithm = 'pbkdf2_sha256_custom'
-    iterations = getattr(settings,"RECOVERY_ITERATION",1)
-
-def delTokens(request):
-    #Only when all MFA have been deactivated, or to generate new !
-    #We iterate only to clean if any error happend and multiple entry of RECOVERY created for one user
-    for key in User_Keys.objects.filter(username=request.user.username, key_type = "RECOVERY"):
-        if key.username == request.user.username:
-            key.delete()
-
-def randomGen(n):
-    return ''.join(random.choice(string.ascii_uppercase + string.ascii_lowercase + string.digits) for _ in range(n))
-
-@never_cache
-def genTokens(request):
-    #Delete old ones
-    delTokens(request)
-    #Then generate new one
-    salt = randomGen(15)
-    hashedKeys = []
-    clearKeys = []
-    for i in range(5):
-            token = randomGen(5) + "-" + randomGen(5)
-            hashedToken = make_password(token, salt, 'pbkdf2_sha256_custom')
-            hashedKeys.append(hashedToken)
-            clearKeys.append(token)
-    uk=User_Keys()
-
-    uk.username = request.user.username
-    uk.properties={"secret_keys":hashedKeys, "salt":salt}
-    uk.key_type="RECOVERY"
-    uk.enabled = True
-    uk.save()
-    return HttpResponse(simplejson.dumps({"keys":clearKeys}))
-
-
-def verify_login(request, username, token):
-    for key in User_Keys.objects.filter(username=username, key_type = "RECOVERY"):
-        secret_keys = key.properties["secret_keys"]
-        salt = key.properties["salt"]
-        hashedToken = make_password(token, salt, "pbkdf2_sha256_custom")
-        for i,token in enumerate(secret_keys):
-            if hashedToken == token:
-                secret_keys.pop(i)
-                key.properties["secret_keys"] = secret_keys
-                key.last_used= timezone.now()
-                key.save()
-                return [True, key.id, len(secret_keys) == 0]
-    return [False]
-
-def getTokenLeft(request):
-    uk = User_Keys.objects.filter(username=request.user.username, key_type = "RECOVERY")
-    keyLeft=0
-    for key in uk:
-        keyLeft += len(key.properties["secret_keys"])
-    return HttpResponse(simplejson.dumps({"left":keyLeft}))
-
-def recheck(request):
-    context = csrf(request)
-    context["mode"]="recheck"
-    if request.method == "POST":
-        if verify_login(request,request.user.username, token=request.POST["recovery"])[0]:
-            import time
-            request.session["mfa"]["rechecked_at"] = time.time()
-            return HttpResponse(simplejson.dumps({"recheck": True}), content_type="application/json")
-        else:
-            return HttpResponse(simplejson.dumps({"recheck": False}), content_type="application/json")
-    return render(request,"RECOVERY/recheck.html", context)
-
-@never_cache
-def auth(request):
-    from .views import login
-    context=csrf(request)
-    if request.method=="POST":
-        tokenLength = len(request.POST["recovery"])
-        if tokenLength == 11 and "RECOVERY" not in settings.MFA_UNALLOWED_METHODS:
-            #Backup code check
-            resBackup=verify_login(request, request.session["base_username"], token=request.POST["recovery"])
-            if resBackup[0]:
-                mfa = {"verified": True, "method": "RECOVERY","id":resBackup[1], "lastBackup":resBackup[2]}
-                # if getattr(settings, "MFA_RECHECK", False):
-                #     mfa["next_check"] = datetime.datetime.timestamp((datetime.datetime.now()
-                #                             + datetime.timedelta(
-                #                 seconds=random.randint(settings.MFA_RECHECK_MIN, settings.MFA_RECHECK_MAX))))
-                request.session["mfa"] = mfa
-                if resBackup[2]:
-                    #If the last bakup code has just been used, we return a response insead of redirecting to login
-                    context["lastBackup"] = True
-                    return render(request,"RECOVERY/Auth.html", context)                
-                return login(request)
-        context["invalid"]=True
-
-    elif request.method=="GET":
-        mfa = request.session.get("mfa")
-        if mfa and mfa["verified"] and mfa["lastBackup"]:
-            return login(request)
-
-    return render(request,"RECOVERY/Auth.html", context)
-
-@never_cache
-def start(request):
-    """Start Managing recovery tokens"""
-    context = get_redirect_url()
-    if "mfa_reg" in request.session:
-        context["mfa_redirect"] = request.session["mfa_reg"]["name"]
-    return render(request,"RECOVERY/Add.html",context)

mfa/static/mfa/js/base64url.js

@@ -1,73 +0,0 @@
-(function(){
-            'use strict';
-
-            let chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-_';
-
-            // Use a lookup table to find the index.
-            let lookup = new Uint8Array(256);
-            for (let i = 0; i < chars.length; i++) {
-                lookup[chars.charCodeAt(i)] = i;
-            }
-
-            let encode = function(arraybuffer) {
-                let bytes = new Uint8Array(arraybuffer),
-                i, len = bytes.length, base64url = '';
-
-                for (i = 0; i < len; i+=3) {
-                    base64url += chars[bytes[i] >> 2];
-                    base64url += chars[((bytes[i] & 3) << 4) | (bytes[i + 1] >> 4)];
-                    base64url += chars[((bytes[i + 1] & 15) << 2) | (bytes[i + 2] >> 6)];
-                    base64url += chars[bytes[i + 2] & 63];
-                }
-
-                if ((len % 3) === 2) {
-                    base64url = base64url.substring(0, base64url.length - 1);
-                } else if (len % 3 === 1) {
-                    base64url = base64url.substring(0, base64url.length - 2);
-                }
-
-                return base64url;
-            };
-
-            let decode = function(base64string) {
-                let bufferLength = base64string.length * 0.75,
-                len = base64string.length, i, p = 0,
-                encoded1, encoded2, encoded3, encoded4;
-
-                let bytes = new Uint8Array(bufferLength);
-
-                for (i = 0; i < len; i+=4) {
-                    encoded1 = lookup[base64string.charCodeAt(i)];
-                    encoded2 = lookup[base64string.charCodeAt(i+1)];
-                    encoded3 = lookup[base64string.charCodeAt(i+2)];
-                    encoded4 = lookup[base64string.charCodeAt(i+3)];
-
-                    bytes[p++] = (encoded1 << 2) | (encoded2 >> 4);
-                    bytes[p++] = ((encoded2 & 15) << 4) | (encoded3 >> 2);
-                    bytes[p++] = ((encoded3 & 3) << 6) | (encoded4 & 63);
-                }
-
-                return bytes.buffer
-            };
-
-            let methods = {
-                'decode': decode,
-                'encode': encode
-            }
-
-            /**
-             * Exporting and stuff
-             */
-            if (typeof module !== 'undefined' && typeof module.exports !== 'undefined') {
-                module.exports = methods;
-
-            } else {
-                if (typeof define === 'function' && define.amd) {
-                    define([], function() {
-                        return methods
-                    });
-                } else {
-                    window.base64url = methods;
-                }
-            }
-        })();

mfa/static/mfa/js/cbor.js

@@ -0,0 +1,406 @@
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2014-2016 Patrick Gansterer <paroga@paroga.com>
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+(function(global, undefined) { "use strict";
+var POW_2_24 = 5.960464477539063e-8,
+    POW_2_32 = 4294967296,
+    POW_2_53 = 9007199254740992;
+
+function encode(value) {
+  var data = new ArrayBuffer(256);
+  var dataView = new DataView(data);
+  var lastLength;
+  var offset = 0;
+
+  function prepareWrite(length) {
+    var newByteLength = data.byteLength;
+    var requiredLength = offset + length;
+    while (newByteLength < requiredLength)
+      newByteLength <<= 1;
+    if (newByteLength !== data.byteLength) {
+      var oldDataView = dataView;
+      data = new ArrayBuffer(newByteLength);
+      dataView = new DataView(data);
+      var uint32count = (offset + 3) >> 2;
+      for (var i = 0; i < uint32count; ++i)
+        dataView.setUint32(i << 2, oldDataView.getUint32(i << 2));
+    }
+
+    lastLength = length;
+    return dataView;
+  }
+  function commitWrite() {
+    offset += lastLength;
+  }
+  function writeFloat64(value) {
+    commitWrite(prepareWrite(8).setFloat64(offset, value));
+  }
+  function writeUint8(value) {
+    commitWrite(prepareWrite(1).setUint8(offset, value));
+  }
+  function writeUint8Array(value) {
+    var dataView = prepareWrite(value.length);
+    for (var i = 0; i < value.length; ++i)
+      dataView.setUint8(offset + i, value[i]);
+    commitWrite();
+  }
+  function writeUint16(value) {
+    commitWrite(prepareWrite(2).setUint16(offset, value));
+  }
+  function writeUint32(value) {
+    commitWrite(prepareWrite(4).setUint32(offset, value));
+  }
+  function writeUint64(value) {
+    var low = value % POW_2_32;
+    var high = (value - low) / POW_2_32;
+    var dataView = prepareWrite(8);
+    dataView.setUint32(offset, high);
+    dataView.setUint32(offset + 4, low);
+    commitWrite();
+  }
+  function writeTypeAndLength(type, length) {
+    if (length < 24) {
+      writeUint8(type << 5 | length);
+    } else if (length < 0x100) {
+      writeUint8(type << 5 | 24);
+      writeUint8(length);
+    } else if (length < 0x10000) {
+      writeUint8(type << 5 | 25);
+      writeUint16(length);
+    } else if (length < 0x100000000) {
+      writeUint8(type << 5 | 26);
+      writeUint32(length);
+    } else {
+      writeUint8(type << 5 | 27);
+      writeUint64(length);
+    }
+  }
+
+  function encodeItem(value) {
+    var i;
+
+    if (value === false)
+      return writeUint8(0xf4);
+    if (value === true)
+      return writeUint8(0xf5);
+    if (value === null)
+      return writeUint8(0xf6);
+    if (value === undefined)
+      return writeUint8(0xf7);
+
+    switch (typeof value) {
+      case "number":
+        if (Math.floor(value) === value) {
+          if (0 <= value && value <= POW_2_53)
+            return writeTypeAndLength(0, value);
+          if (-POW_2_53 <= value && value < 0)
+            return writeTypeAndLength(1, -(value + 1));
+        }
+        writeUint8(0xfb);
+        return writeFloat64(value);
+
+      case "string":
+        var utf8data = [];
+        for (i = 0; i < value.length; ++i) {
+          var charCode = value.charCodeAt(i);
+          if (charCode < 0x80) {
+            utf8data.push(charCode);
+          } else if (charCode < 0x800) {
+            utf8data.push(0xc0 | charCode >> 6);
+            utf8data.push(0x80 | charCode & 0x3f);
+          } else if (charCode < 0xd800) {
+            utf8data.push(0xe0 | charCode >> 12);
+            utf8data.push(0x80 | (charCode >> 6)  & 0x3f);
+            utf8data.push(0x80 | charCode & 0x3f);
+          } else {
+            charCode = (charCode & 0x3ff) << 10;
+            charCode |= value.charCodeAt(++i) & 0x3ff;
+            charCode += 0x10000;
+
+            utf8data.push(0xf0 | charCode >> 18);
+            utf8data.push(0x80 | (charCode >> 12)  & 0x3f);
+            utf8data.push(0x80 | (charCode >> 6)  & 0x3f);
+            utf8data.push(0x80 | charCode & 0x3f);
+          }
+        }
+
+        writeTypeAndLength(3, utf8data.length);
+        return writeUint8Array(utf8data);
+
+      default:
+        var length;
+        if (Array.isArray(value)) {
+          length = value.length;
+          writeTypeAndLength(4, length);
+          for (i = 0; i < length; ++i)
+            encodeItem(value[i]);
+        } else if (value instanceof Uint8Array) {
+          writeTypeAndLength(2, value.length);
+          writeUint8Array(value);
+        } else {
+          var keys = Object.keys(value);
+          length = keys.length;
+          writeTypeAndLength(5, length);
+          for (i = 0; i < length; ++i) {
+            var key = keys[i];
+            encodeItem(key);
+            encodeItem(value[key]);
+          }
+        }
+    }
+  }
+
+  encodeItem(value);
+
+  if ("slice" in data)
+    return data.slice(0, offset);
+
+  var ret = new ArrayBuffer(offset);
+  var retView = new DataView(ret);
+  for (var i = 0; i < offset; ++i)
+    retView.setUint8(i, dataView.getUint8(i));
+  return ret;
+}
+
+function decode(data, tagger, simpleValue) {
+  var dataView = new DataView(data);
+  var offset = 0;
+
+  if (typeof tagger !== "function")
+    tagger = function(value) { return value; };
+  if (typeof simpleValue !== "function")
+    simpleValue = function() { return undefined; };
+
+  function commitRead(length, value) {
+    offset += length;
+    return value;
+  }
+  function readArrayBuffer(length) {
+    return commitRead(length, new Uint8Array(data, offset, length));
+  }
+  function readFloat16() {
+    var tempArrayBuffer = new ArrayBuffer(4);
+    var tempDataView = new DataView(tempArrayBuffer);
+    var value = readUint16();
+
+    var sign = value & 0x8000;
+    var exponent = value & 0x7c00;
+    var fraction = value & 0x03ff;
+
+    if (exponent === 0x7c00)
+      exponent = 0xff << 10;
+    else if (exponent !== 0)
+      exponent += (127 - 15) << 10;
+    else if (fraction !== 0)
+      return (sign ? -1 : 1) * fraction * POW_2_24;
+
+    tempDataView.setUint32(0, sign << 16 | exponent << 13 | fraction << 13);
+    return tempDataView.getFloat32(0);
+  }
+  function readFloat32() {
+    return commitRead(4, dataView.getFloat32(offset));
+  }
+  function readFloat64() {
+    return commitRead(8, dataView.getFloat64(offset));
+  }
+  function readUint8() {
+    return commitRead(1, dataView.getUint8(offset));
+  }
+  function readUint16() {
+    return commitRead(2, dataView.getUint16(offset));
+  }
+  function readUint32() {
+    return commitRead(4, dataView.getUint32(offset));
+  }
+  function readUint64() {
+    return readUint32() * POW_2_32 + readUint32();
+  }
+  function readBreak() {
+    if (dataView.getUint8(offset) !== 0xff)
+      return false;
+    offset += 1;
+    return true;
+  }
+  function readLength(additionalInformation) {
+    if (additionalInformation < 24)
+      return additionalInformation;
+    if (additionalInformation === 24)
+      return readUint8();
+    if (additionalInformation === 25)
+      return readUint16();
+    if (additionalInformation === 26)
+      return readUint32();
+    if (additionalInformation === 27)
+      return readUint64();
+    if (additionalInformation === 31)
+      return -1;
+    throw "Invalid length encoding";
+  }
+  function readIndefiniteStringLength(majorType) {
+    var initialByte = readUint8();
+    if (initialByte === 0xff)
+      return -1;
+    var length = readLength(initialByte & 0x1f);
+    if (length < 0 || (initialByte >> 5) !== majorType)
+      throw "Invalid indefinite length element";
+    return length;
+  }
+
+  function appendUtf16Data(utf16data, length) {
+    for (var i = 0; i < length; ++i) {
+      var value = readUint8();
+      if (value & 0x80) {
+        if (value < 0xe0) {
+          value = (value & 0x1f) <<  6
+                | (readUint8() & 0x3f);
+          length -= 1;
+        } else if (value < 0xf0) {
+          value = (value & 0x0f) << 12
+                | (readUint8() & 0x3f) << 6
+                | (readUint8() & 0x3f);
+          length -= 2;
+        } else {
+          value = (value & 0x0f) << 18
+                | (readUint8() & 0x3f) << 12
+                | (readUint8() & 0x3f) << 6
+                | (readUint8() & 0x3f);
+          length -= 3;
+        }
+      }
+
+      if (value < 0x10000) {
+        utf16data.push(value);
+      } else {
+        value -= 0x10000;
+        utf16data.push(0xd800 | (value >> 10));
+        utf16data.push(0xdc00 | (value & 0x3ff));
+      }
+    }
+  }
+
+  function decodeItem() {
+    var initialByte = readUint8();
+    var majorType = initialByte >> 5;
+    var additionalInformation = initialByte & 0x1f;
+    var i;
+    var length;
+
+    if (majorType === 7) {
+      switch (additionalInformation) {
+        case 25:
+          return readFloat16();
+        case 26:
+          return readFloat32();
+        case 27:
+          return readFloat64();
+      }
+    }
+
+    length = readLength(additionalInformation);
+    if (length < 0 && (majorType < 2 || 6 < majorType))
+      throw "Invalid length";
+
+    switch (majorType) {
+      case 0:
+        return length;
+      case 1:
+        return -1 - length;
+      case 2:
+        if (length < 0) {
+          var elements = [];
+          var fullArrayLength = 0;
+          while ((length = readIndefiniteStringLength(majorType)) >= 0) {
+            fullArrayLength += length;
+            elements.push(readArrayBuffer(length));
+          }
+          var fullArray = new Uint8Array(fullArrayLength);
+          var fullArrayOffset = 0;
+          for (i = 0; i < elements.length; ++i) {
+            fullArray.set(elements[i], fullArrayOffset);
+            fullArrayOffset += elements[i].length;
+          }
+          return fullArray;
+        }
+        return readArrayBuffer(length);
+      case 3:
+        var utf16data = [];
+        if (length < 0) {
+          while ((length = readIndefiniteStringLength(majorType)) >= 0)
+            appendUtf16Data(utf16data, length);
+        } else
+          appendUtf16Data(utf16data, length);
+        return String.fromCharCode.apply(null, utf16data);
+      case 4:
+        var retArray;
+        if (length < 0) {
+          retArray = [];
+          while (!readBreak())
+            retArray.push(decodeItem());
+        } else {
+          retArray = new Array(length);
+          for (i = 0; i < length; ++i)
+            retArray[i] = decodeItem();
+        }
+        return retArray;
+      case 5:
+        var retObject = {};
+        for (i = 0; i < length || length < 0 && !readBreak(); ++i) {
+          var key = decodeItem();
+          retObject[key] = decodeItem();
+        }
+        return retObject;
+      case 6:
+        return tagger(decodeItem(), length);
+      case 7:
+        switch (length) {
+          case 20:
+            return false;
+          case 21:
+            return true;
+          case 22:
+            return null;
+          case 23:
+            return undefined;
+          default:
+            return simpleValue(length);
+        }
+    }
+  }
+
+  var ret = decodeItem();
+  if (offset !== data.byteLength)
+    throw "Remaining bytes";
+  return ret;
+}
+
+var obj = { encode: encode, decode: decode };
+
+if (typeof define === "function" && define.amd)
+  define("cbor/cbor", obj);
+else if (typeof module !== "undefined" && module.exports)
+  module.exports = obj;
+else if (!global.CBOR)
+  global.CBOR = obj;
+
+})(this);

mfa/static/mfa/js/helpers.js

@@ -1,25 +0,0 @@
-var publicKeyCredentialToJSON = (pubKeyCred) => {
-            if(pubKeyCred instanceof Array) {
-                let arr = [];
-                for(let i of pubKeyCred)
-                    arr.push(publicKeyCredentialToJSON(i));
-
-                return arr
-            }
-
-            if(pubKeyCred instanceof ArrayBuffer) {
-                return base64url.encode(pubKeyCred)
-            }
-
-            if(pubKeyCred instanceof Object) {
-                let obj = {};
-
-                for (let key in pubKeyCred) {
-                    obj[key] = publicKeyCredentialToJSON(pubKeyCred[key])
-                }
-
-                return obj
-            }
-
-            return pubKeyCred
-        }

mfa/templates/FIDO2/Add.html

@@ -1,39 +1,29 @@
 {% extends "base.html" %}
 {% load static %}
 {% block head %}
+    <script type="application/javascript" src="{% static 'mfa/js/cbor.js'%}"></script>
     <script type="application/javascript" src="{% static 'mfa/js/ua-parser.min.js'%}"></script>
-    <script type="application/javascript" src="{% static 'mfa/js/base64url.js'%}"></script>
-    <script type="application/javascript" src="{% static 'mfa/js/helpers.js'%}"></script>
     <script type="application/javascript">
-    var MakeCredReq = (makeCredReq) => {
-            makeCredReq.publicKey.challenge = base64url.decode(makeCredReq.publicKey.challenge);
-            makeCredReq.publicKey.user.id   = base64url.decode(makeCredReq.publicKey.user.id);
-
-            for(let excludeCred of makeCredReq.publicKey.excludeCredentials) {
-                excludeCred.id = base64url.decode(excludeCred.id);
-            }
-
-            return makeCredReq
-        }
     function begin_reg(){
     fetch('{% url 'fido2_begin_reg' %}',{}).then(function(response) {
       if(response.ok)
       {
-          return response.json().then(function (req){
-              return MakeCredReq(req)
-          });
+          return response.arrayBuffer();
       }
       throw new Error('Error getting registration data!');
-    }).then(function(options) {
-
-        //options.publicKey.attestation="direct"
+    }).then(CBOR.decode).then(function(options) {
+        options.publicKey.attestation="direct"
         console.log(options)
 
       return navigator.credentials.create(options);
     }).then(function(attestation) {
       return fetch('{% url 'fido2_complete_reg' %}', {
         method: 'POST',
-        body: JSON.stringify(publicKeyCredentialToJSON(attestation))
+        headers: {'Content-Type': 'application/cbor'},
+        body: CBOR.encode({
+          "attestationObject": new Uint8Array(attestation.response.attestationObject),
+          "clientDataJSON": new Uint8Array(attestation.response.clientDataJSON),
+        })
       });
     }).then(function(response) {
 
@@ -43,11 +33,6 @@
         {
       if (res["status"] =='OK')
             $("#res").html("<div class='alert alert-success'>Registered Successfully, <a href='{{redirect_html}}'> {{reg_success_msg}}</a></div>")
-      else if (res['status'] = "RECOVERY")
-      {
-          setTimeout(function (){location.href="{% url 'manage_recovery_codes' %}"},2500)
-        $("#res").html("<div class='alert alert-success'>Registered Successfully, but <a href='{% url 'manage_recovery_codes' %}'>redirecting to {{ RECOVERY_METHOD }} method</a></div>")
-      }
         else
             $("#res").html("<div class='alert alert-danger'>Registration Failed as " + res["message"] + ", <a href='javascript:void(0)' onclick='begin_reg()'> try again or <a href='{% url 'mfa_home' %}'> Go to Security Home</a></div>")
 
@@ -76,7 +61,7 @@
      <div class="container">
      <div class="panel panel-default card">
       <div class="panel-heading card-header">
-	      <strong> Adding a New {{ method.name }}</strong>
+	      <strong> FIDO2 Security Key</strong>
       </div>
       <div class="panel-body card-body">
 

mfa/templates/FIDO2/Auth_JS.html

@@ -1,80 +0,0 @@
-{% load static %}
-<script type="application/javascript" src="{% static 'mfa/js/base64url.js' %}"></script>
-<script type="application/javascript" src="{% static 'mfa/js/helpers.js' %}"></script>
-<script type="application/javascript" src="{% static 'mfa/js/ua-parser.min.js' %}"></script>
-<script type="text/javascript">
-var GetAssertReq = (getAssert) => {
-           getAssert.publicKey.challenge = base64url.decode(getAssert.publicKey.challenge);
-
-            for(let allowCred of getAssert.publicKey.allowCredentials) {
-                allowCred.id = base64url.decode(allowCred.id);
-            }
-
-            return getAssert
-        }
-        function authen()
-        {
-         fetch('{% url 'fido2_begin_auth' %}', {
-      method: 'GET',
-    }).then(function(response) {
-      if(response.ok) {
-          return response.json().then(function (req){
-              return GetAssertReq(req)
-          });
-      }
-      throw new Error('No credential available to authenticate!');
-    }).then(function(options) {
-        console.log(options)
-      return navigator.credentials.get(options);
-    }).then(function(assertion) {
-
-
-      return fetch('{% url 'fido2_complete_auth' %}', {
-
-        method: 'POST',
-        headers: {'Content-Type': 'application/json'},
-        body:JSON.stringify(publicKeyCredentialToJSON(assertion)),
-
-      }).then(function (response) {if (response.ok) return res = response.json()}).then(function (res) {
-          if (res.status=="OK")
-          {
-              $("#msgdiv").addClass("alert alert-success").removeClass("alert-danger")
-             $("#msgdiv").html("Verified....please wait")
-          {%  if mode == "auth" or mode == None %}
-          window.location.href=res.redirect;
-          {% elif mode == "recheck" %}
-              mfa_success_function();
-          {% endif %}
-          }
-          else {
-              $("#msgdiv").addClass("alert alert-danger").removeClass("alert-success")
-                $("#msgdiv").html("Verification Failed as " + res.message + ", <a href='javascript:void(0)' onclick='authen())'> try again</a> or <a href='javascript:void(0)' onclick='history.back()'> Go Back</a>")
-
-              {%  if mode == "auth" %}
-
-              {% elif mode == "recheck" %}
-
-                mfa_failed_function();
-              {% endif %}
-          }
-      })
-
-                 })
-
-        }
-    $(document).ready(function () {
-        if (location.protocol != 'https:') {
-            $("#main_paragraph").addClass("alert alert-danger")
-            $("#main_paragraph").html("FIDO2 must work under secure context")
-        } else {
-            ua=new UAParser().getResult()
-            if (ua.browser.name == "Safari" || ua.browser.name == "Mobile Safari" || ua.os.name == "iOS" || ua.os.name == "iPadOS")
-                $("#res").html("<button class='btn btn-success' onclick='authen()'>Authenticate...</button>")
-            else
-                authen()
-        }
-    });
-
-
-
-    </script>

mfa/templates/FIDO2/recheck.html

@@ -1,7 +1,9 @@
 {%  load static %}
+<script type="application/javascript" src="{% static 'mfa/js/cbor.js' %}"></script>
+<script type="application/javascript" src="{% static 'mfa/js/ua-parser.min.js' %}"></script>
 <div class="row">
 
-<div class="col-sm-10 col-sm-offset-1 col-xs-12 col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2 offset-2 col-8">
+<div class="col-sm-10 col-sm-offset-1 col-xs-12 col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2">
 <div class="panel panel-default card">
       <div class="panel-heading card-header">
 	      <strong> Security Key</strong>
@@ -33,7 +35,7 @@
           </div>
 
           <div class="row">
-          <div class="col-md-12 mb-3" style="padding-left: 25px">
+          <div class="col-md-12 mb-3" style="padding-left: 15px">
 
             {% if request.session.mfa_methods|length > 1 %}
                 <a href="{%  url 'mfa_methods_list' %}">Select Another Method</a>
@@ -45,4 +47,71 @@
 </div>
 </div>
 
-    {% include 'FIDO2/Auth_JS.html' %}
+    <script type="text/javascript">
+        function authen()
+        {
+                         fetch('{% url 'fido2_begin_auth' %}', {
+      method: 'GET',
+    }).then(function(response) {
+      if(response.ok) return response.arrayBuffer();
+      throw new Error('No credential available to authenticate!');
+    }).then(CBOR.decode).then(function(options) {
+        console.log(options)
+      return navigator.credentials.get(options);
+    }).then(function(assertion) {
+        res=CBOR.encode({
+          "credentialId": new Uint8Array(assertion.rawId),
+          "authenticatorData": new Uint8Array(assertion.response.authenticatorData),
+          "clientDataJSON": new Uint8Array(assertion.response.clientDataJSON),
+          "signature": new Uint8Array(assertion.response.signature)
+        });
+
+      return fetch('{% url 'fido2_complete_auth' %}', {
+
+        method: 'POST',
+        headers: {'Content-Type': 'application/cbor'},
+        body:res,
+
+      }).then(function (response) {if (response.ok) return res = response.json()}).then(function (res) {
+          if (res.status=="OK")
+          {
+              $("#msgdiv").addClass("alert alert-success").removeClass("alert-danger")
+             $("#msgdiv").html("Verified....please wait")
+          {%  if mode == "auth" %}
+          window.location.href=res.redirect;
+          {% elif mode == "recheck" %}
+              mfa_success_function();
+          {% endif %}
+          }
+          else {
+              $("#msgdiv").addClass("alert alert-danger").removeClass("alert-success")
+                $("#msgdiv").html("Verification Failed as " + res.message + ", <a href='javascript:void(0)' onclick='authen())'> try again</a> or <a href='javascript:void(0)' onclick='history.back()'> Go Back</a>")
+
+              {%  if mode == "auth" %}
+
+              {% elif mode == "recheck" %}
+
+                mfa_failed_function();
+              {% endif %}
+          }
+      })
+
+                 })
+
+        }
+    $(document).ready(function () {
+        if (location.protocol != 'https:') {
+            $("#main_paragraph").addClass("alert alert-danger")
+            $("#main_paragraph").html("FIDO2 must work under secure context")
+        } else {
+            ua=new UAParser().getResult()
+            if (ua.browser.name == "Safari" || ua.browser.name == "Mobile Safari" || ua.os.name == "iOS" || ua.os.name == "iPadOS")
+                $("#res").html("<button class='btn btn-success' onclick='authen()'>Authenticate...</button>")
+            else
+                authen()
+        }
+    });
+
+
+
+    </script>

mfa/templates/MFA.html

@@ -45,31 +45,31 @@
     <br/>
     <div class="container">
     <div class="row">
-        <div class="offset-5 col-2" style="text-align: center">
+        <div align="center">
             <div class="btn-group">
             <button class="btn btn-success dropdown-toggle" data-toggle="dropdown" data-bs-toggle="dropdown">
                 Add Method&nbsp;<span class="caret"></span>
             </button>
             <ul class="dropdown-menu">
                 {% if not 'TOTP' in UNALLOWED_AUTHEN_METHODS %}
-                    <li><a class="dropdown-item" href="{% url 'start_new_otop' %}">{% if 'TOTP' in RENAME_METHODS.keys %}{{ RENAME_METHODS.TOTP }}{% else %}Authenticator app{% endif %}</a></li>
+                    <li><a class="dropdown-item" href="{% url 'start_new_otop' %}">Authenticator app</a></li>
                 {% endif %}
                 {% if not 'Email' in UNALLOWED_AUTHEN_METHODS %}
-                    <li><a class="dropdown-item" href="{% url 'start_email' %}">{% if 'Email' in RENAME_METHODS.keys %}{{ RENAME_METHODS.Email }}{% else %}Email Token{% endif %}</a></li>
+                    <li><a class="dropdown-item" href="{% url 'start_email' %}">Email Token</a></li>
                 {% endif %}
                 {% if not 'U2F' in UNALLOWED_AUTHEN_METHODS %}
-                    <li><a class="dropdown-item" href="{% url 'start_u2f' %}">{% if 'U2F' in RENAME_METHODS.keys %}{{ RENAME_METHODS.U2F }}{% else %}Security Key{% endif %}</a></li>
+                    <li><a class="dropdown-item" href="{% url 'start_u2f' %}">Security Key</a></li>
                 {% endif %}
             {% if not 'FIDO2' in UNALLOWED_AUTHEN_METHODS %}
-                    <li><a class="dropdown-item" href="{% url 'start_fido2' %}">{% if 'FIDO2' in RENAME_METHODS.keys %}{{ RENAME_METHODS.FIDO2 }}{% else %}FIDO2 Security Key{% endif %}</a></li>
+                    <li><a class="dropdown-item" href="{% url 'start_fido2' %}">FIDO2 Security Key</a></li>
                 {% endif %}
             {% if not 'Trusted_Devices' in UNALLOWED_AUTHEN_METHODS %}
-                    <li><a class="dropdown-item" href="{% url 'start_td' %}">{% if 'Trusted_Devices' in  RENAME_METHODS.keys %}{{ RENAME_METHODS.Trusted_Devices }}{% else %}Trusted Device{% endif %}</a></li>
+                    <li><a class="dropdown-item" href="{% url 'start_td' %}">Trusted Device</a></li>
                 {% endif %}
             </ul>
             </div>
         </div>
-    </div>
+    <br/>
     <br/>
        <table class="table table-striped">
            <tr>
@@ -82,15 +82,14 @@
                <th>Status</th>
                <th>Delete</th>
            </tr>
-        {% if keys %}
         {% for key in keys %}
            <tr>
 
-                <td>{{ key.name }}</td>
+               <td>{{ key.key_type }}</td>
                <td>{{ key.added_on }}</td>
-                <td>{% if key.expires %}{{ key.expires }}{% else %}N/A{% endif %}</td>
+               <td>{{ key.expires }}</td>
                <td>{% if key.device %}{{ key.device }}{% endif %}</td>
-                <td>{% if key.last_used %}{{ key.last_used }}{% else %}Never{% endif %}</td>
+               <td>{{ key.last_used }}</td>
                 {% if key.key_type in HIDE_DISABLE %}
                     <td>{% if key.enabled %}On{% else %} Off{% endif %}</td>
                 {% else %}
@@ -102,22 +101,9 @@
                     <a href="javascript:void(0)" onclick="deleteKey({{ key.id }},'{{ key.key_type }}')"> <span class="fa fa-trash fa-solid fa-trash-can bi bi-trash-fill"></span></a></td>
                     {% endif %}
            </tr>
-            {% endfor %}
-            {% if "RECOVERY" not in UNALLOWED_AUTHEN_METHODS %}
-            <tr>
-
-                <td>{{ recovery.name }}</td>
-                <td>{{ recovery.added_on }}</td>
-                <td>N/A</td>
-                <td>N/A</td>
-                <td>{% if recovery.last_used %}{{ recovery.last_used }}{% else %}Never{% endif %}</td>
-                <td>On</td>
-                <td><a href="{% url 'manage_recovery_codes' %}"> <span class="fa fa-wrench fa-solid fa-wrench bi bi-wrench-fill"></span></a></td>
-            </tr>
-            {% endif %}
-        {% else %}
+       {% empty %}
            <tr><td colspan="7" align="center">You didn't have any keys yet.</td> </tr>
-       {% endif %}
+       {% endfor %}
         </table>
     </div>
     </div>

mfa/templates/RECOVERY/Add.html

@@ -1,134 +0,0 @@
-
-{% extends "base.html" %}
-{% load static %}
-{% block head %}
-<style>
-    #two-factor-steps {
-	border: 1px solid #ccc;
-	border-radius: 3px;
-	padding: 15px;
-    }
-    .tokenrow{
-        margin-top: 10px;
-        margin-left: 5px;
-    }
-    .row{
-        margin: 3px;
-    }
-    .toolbtn {
-        border-radius: 7px;
-        cursor: pointer;
-    }
-    .toolbtn:hover {
-        background-color: gray;
-        transition: 0.2s;
-    }
-    .toolbtn:active {
-        background-color: green;
-        transition: 0.2s;
-    }
-</style>
-
-<script src="{% static 'mfa/js/qrious.min.js' %}" type="text/javascript"></script>
-<script type="text/javascript">
-    var clearCodes;
-    $(document).ready(function checkTokenLeft() {
-        $.ajax({"url":"{% url 'get_recovery_token_left' %}", dataType:"JSON",
-        success:function (data) {
-            tokenLeft = data.left
-            html = ""
-            {% if mfa_redirect %}
-                html += "<div class='alert alert-success'>You have enrolled successfully in {{ mfa_redirect }} method, please generate recovery codes so that you can use in case you lost access to all your verification methods.</div>"
-            {% endif %}
-            if (tokenLeft == 0) {
-                html += "<h6>You don't have any backup code linked to your account, please generate new ones !</h6>"
-                
-            }
-            else {
-                html += "<p>You still have "+tokenLeft+" backup code left."
-            }
-            document.getElementById('tokens').innerHTML = html
-        }})
-    });
-    function confirmRegenerateTokens() {
-        htmlModal = "<h6>Caution! you can only view these token now, else you will need to generate new ones.</h6><div align='center'><button onclick='regenerateTokens()' class='btn btn-success'>Regenerate</button></div>"
-        $("#modal-title").html("Regenerate your recovery Codes?")
-        $("#modal-body").html(htmlModal)
-        $("#popUpModal").modal('show')
-    }
-    function copy() {
-        navigator.clipboard.writeText($("#recovery_codes").text());
-    }
-    function regenerateTokens() {
-        $.ajax({
-            "url":"{% url 'regen_recovery_tokens' %}", dataType:"JSON",
-            success:function (data) {
-                let htmlkey=`<p>Here are the recovery codes, you have to save them now as you won't able to view them again.</p>
-                <div class='row'><div class='offset-4 col-md-4' style='background-color:#f0f0f0;padding: 10px'>
-                    <div class='row'>
-                    <div class="col-6 offset-6">
-                    <span onclick='download_recovery()' class='fa fa-download toolbtn' title="Download"></span>&nbsp;&nbsp;
-                    <span class='fa fa-clipboard toolbtn' title="Copy" onclick="copy()"></span>
-                    </div></div><div id='recovery_codes'><pre>`;
-                for (let i = 0; i < data.keys.length; i++) {
-                        htmlkey +="- " +data.keys[i] + "\n"
-                }
-                document.getElementById('tokens').innerHTML = htmlkey+"</pre></div></div></div>"
-                $("#popUpModal").modal('hide')
-                clearCodes = data.keys
-            }
-        })
-    }
-    function download_recovery() {
-        var element = document.createElement('a');
-        var text = "";
-        for(let i = 0; i < clearCodes.length; i++)
-        {
-            text = text + clearCodes[i] 
-            if (i < clearCodes.length - 1) { text = text + "\n"}
-        }
-        element.setAttribute('href', 'data:text/plain;charset=utf-8,' + encodeURIComponent(text));
-        element.setAttribute('download', 'Recovery Codes.txt');
-        element.style.display = 'none';
-        document.body.appendChild(element);
-        element.click();
-        console.log(element.innerHTML)
-        document.body.removeChild(element);
-    }
-    </script>
-{% endblock %}
-{% block content %}
-<br/>
-<br/>
-<div class="container d-flex justify-content-center">
-    <div class="col-md-6 col-md-offset-3" id="two-factor-steps">
-        
-        <div class="row">
-            
-            <h4>Recovery Codes List</h4>
-        
-        </div>
-            
-        <div class="tokenrow" id="tokens">
-        
-        </div>
-         <br/>
-            <br/>
-        <div class="row">
-
-            <div class="col-md-4 col-md-offset-4" style="padding-left: 0px" align="center">
-
-                <button onclick="confirmRegenerateTokens()" class="btn btn-success">Regenerate</button>
-                
-            </div>
-
-            <div class="col-md-6"  align="right" style="padding-right: 30px">
-
-                <a href="{{redirect_html}}" class="btn btn-default btn-secondary" role="button"> {{reg_success_msg}}</a>
-
-            </div>
-        </div>
-    </div>
-</div>
-{% include "modal.html" %}
-{% endblock %}

mfa/templates/RECOVERY/Auth.html

@@ -1,14 +0,0 @@
-{% extends "mfa_auth_base.html" %}
-{% block head %}
-    <style>
-    .row{
-        margin-left: 15px;
-    }
-    </style>
-{% endblock %}
-{% block content %}
-<br/>
-<br/>
-{% include "RECOVERY/recheck.html" with mode='auth' %}
-
-  {% endblock %}

mfa/templates/RECOVERY/recheck.html

@@ -1,85 +0,0 @@
-<script type="application/javascript">
-    $(document).ready(function showWarningLastBackup() {
-        {% if lastBackup %}
-        $("#modal-title").html("Last backup code used !")
-        $("#modal-body").html("Don't forget to regenerate new backup code after login !")
-        $('#modal-footer').html(`<FORM METHOD="GET" ACTION="{% url 'recovery_auth' %}" Id="confirmLogin" onSubmit="" name="recoveryLastBackupConfirm">
-        <input type='submit'class='btn btn-lg btn-success btn-block' value='Continue'>`)
-        $("#popUpModal").modal('show')
-        {% endif %}
-        return
-    });
-    function send_recovery() {
-        $.ajax({"url":"{% url 'recovery_recheck' %}", method:"POST",dataType:"JSON",
-            data:{"csrfmiddlewaretoken":"{{ csrf_token }}","recovery":$("#recovery").val()},
-         success:function (data) {
-                            if (data["recheck"])
-                                mfa_success_function();
-                            else {
-                                mfa_failed_function();
-                            }
-                        }
-        })
-    }
-</script>
-<div class="row">
-<div class="col-sm-10 col-sm-offset-1 col-xs-12 col-md-10 col-md-offset-1 col-lg-10 col-lg-offset-1">
-<div class="panel panel-default card">
-      <div class="panel-heading card-header">
-	      <strong> Recovery code</strong>
-      </div>
-      <div class="panel-body card-body">
-
-      <FORM METHOD="POST" ACTION="{% url 'recovery_auth' %}" Id="formLogin" onSubmit="" name="FrontPage_Form1">
-
-
-      {% csrf_token %}
-          {%  if invalid %}
-          <div class="alert alert-danger">
-              Sorry, The provided code is not valid, or has already been used.
-          </div>
-          {% endif %}
-      {% if quota %}
-          <div class="alert alert-warning">
-              {{ quota }}
-          </div>
-      {% endif %}
-      <fieldset>
-      <div class="row">
-      <div class="col-sm-12 col-md-12">
-        <p>Enter the 11-digits on your authenticator. Or input a recovery code</p>
-      </div>
-      </div>
-
-      <div class="row">
-	  <div class="col-sm-12 col-md-12">
-	    <div class="form-group">
-	      <div class="input-group mb-3">
-		<span class="input-group-addon input-group-text">
-		<i class="glyphicon glyphicon-lock bi bi-lock"></i>
-		</span>
-		<input class="form-control" size="11" MaxLength="11" value="" placeholder="e.g abcde-fghij" name="recovery" type="text" id="recovery" autofocus>
-
-	      </div>
-	    </div>
-
-          <div class="form-group d-grid gap-2">
-
-            <input type="{% if mode == "auth" %}submit{% elif mode == 'recheck'  %}button{% endif %}" {% if mode == "recheck" %}onclick="send_recovery()" {% endif %} class="btn btn-lg btn-success btn-block" value="Sign in">
-	      </div>
-      </div>
-      </fieldset>
-      </FORM>
-      </div>
-        <div class="row">
-        <div class="col-md-12 mb-3" style="padding-left: 25px">
-            {% if request.session.mfa_methods|length > 1 %}
-                <a href="{%  url 'mfa_methods_list' %}">Select Another Method</a>
-            {% endif %}
-        </div>
-        </div>
-	      </div>
-              </div>
-</div>
-</div>
-{% include "modal.html" %}

mfa/templates/TOTP/Add.html

@@ -7,22 +7,10 @@
 	border: 1px solid #ccc;
 	border-radius: 3px;
 	padding: 15px;
-    }
+}
     .row{
         margin: 0px;
     }
-    .toolbtn {
-        border-radius: 7px;
-        cursor: pointer;
-    }
-    .toolbtn:hover {
-        background-color: gray;
-        transition: 0.2s;
-    }
-    .toolbtn:active {
-        background-color: green;
-        transition: 0.2s;
-    }
     </style>
 <script src="{% static 'mfa/js/qrious.min.js' %}" type="text/javascript"></script>
 <script type="text/javascript">
@@ -41,17 +29,8 @@
         })
     });
     function showKey() {
-        const htmlkey = `
-            <div class="row">
-                <div class="col-11">
-                    <pre id="totp_secret">`+window.key+`</pre>
-                </div>
-                <div class="col-1">
-                    <span onclick=navigator.clipboard.writeText($("#totp_secret").text()) class="fa fa-clipboard toolbtn"></span>
-                </div>
-            </div>`
         $("#modal-title").html("Your Secret Key")
-        $("#modal-body").html(htmlkey)
+        $("#modal-body").html("<pre>"+window.key+"</pre")
         $("#popUpModal").modal('show')
     }
     function verify() {
@@ -59,16 +38,13 @@
         $.ajax({
             "url":"{% url 'verify_otop' %}?key="+key+ "&answer="+answer,
             success:function (data) {
-            if (data =='Success')
-                $("#res").html("<div class='alert alert-success'>Your authenticator is registered successfully, <a href='{{redirect_html}}'> {{reg_success_msg}}</a></div>")
-      else if (data == "RECOVERY")
-      {
-         setTimeout(function (){location.href="{% url 'manage_recovery_codes' %}"},2500)
-        $("#res").html("<div class='alert alert-success'>Your authenticator is registered successfully, but <a href='{% url 'manage_recovery_codes' %}'>redirecting to {{ RECOVERY_METHOD }} method</a></div>")
-      }
+                if (data == "Error")
+                    alert("You entered wrong numbers, please try again")
                 else
-        $("#res").html("<div class='alert alert-danger'>The code provided doesn't match the key, please try again or <a href='{% url 'mfa_home' %}'> Go to Security Home</a></div>")
-
+                {
+                    alert("Your authenticator is added successfully.")
+                    window.location.href="{{ redirect_html }}"
+                }
             }
         })
     }
@@ -90,23 +66,20 @@
 <div class="container d-flex justify-content-center">
     <div class="col-md-6 col-md-offset-3" id="two-factor-steps">
         <div class="row" align="center">
-            <h4>Adding a new {{ method.name }}</h4>
+            <h4>Adding Authenticator</h4>
         </div>
         <div class="row">
 
             <p>Scan the image below with the two-factor authentication app on your <a href="javascript:void(0)" onclick="showTOTP()">phone/PC</a>. If you can’t use a barcode,
                 <a href="javascript:void(0)" onclick="showKey()">enter this text</a> instead. </p>
         </div>
-        <div id="res">
 
-        </div>
-        <div class="row" style="text-align: center">
+        <div class="row">
 
-            <div align="center" style="display: none;text-align: center;align-content: center" id="second_step">
+            <div align="center" style="display: none" id="second_step">
 
                 <img id="qr"/>
 
-            </div>
             </div>
             <div class="row">
 
@@ -115,13 +88,16 @@
 
             </div>
             <div class="row">
-                <div class="offset-md-4 col-md-4">
+
+
                 <input style="display: inline;width: 95%" maxlength="6" size="6" class="form-control" id="answer" placeholder="e.g 785481"/>
-                </div>
+
             </div>
             <div class="row" style="padding-top: 10px;">
-                <div class="col-md-4 offset-md-4" style="padding-left: 0px">
+                <div class="col-md-6" style="padding-left: 0px">
                     <button class="btn btn-success" onclick="verify()">Enable</button>
+                </div>
+                <div class="col-md-6" align="right" style="padding-right: 30px">
                     <a href="{% url 'mfa_home' %}" class="btn btn-default btn-secondary" role="button">Cancel</a>
                 </div>
             </div>

mfa/templates/TOTP/recheck.html

@@ -10,6 +10,7 @@
                             }
                         }
         })
+
     }
 </script>
 <div class='container'>
@@ -39,7 +40,7 @@
       <fieldset>
       <div class="row">
       <div class="col-sm-12 col-md-12">
-        <p>Enter the 6-digits on your authenticator</p>
+        <p>Enter the 6-digits on your authenticator.</p>
       </div>
       </div>
 
@@ -57,7 +58,8 @@
 
           <div class="form-group d-grid gap-2">
 
-            <input type="{% if mode == "auth" %}submit{% elif mode == 'recheck'  %}button{% endif %}" {% if mode == "recheck" %}onclick="send_totp()" {% endif %} class="btn btn-lg btn-success btn-block" value="Sign in">	      </div>
+	      <input type="{% if mode == "auth" %}submit{% elif mode == 'recheck'  %}button{% endif %}" {% if mode == "recheck" %}onclick="send_totp()" {% endif %} class="btn btn-lg btn-success btn-block" value="Sign in">
+	      </div>
       </div>
       </fieldset>
       </FORM>
@@ -74,4 +76,3 @@
 	      </div>
 	      </div>
 </div>
-{% include "modal.html" %}

mfa/templates/U2F/Add.html

@@ -13,7 +13,7 @@
     </style>
     <script src="{% static 'mfa/js/u2f-api.js' %}" type="text/javascript"></script>
     <script type="text/javascript">
-    function addToken() {
+    $(document).ready(function addToken() {
                 data=JSON.parse('{{ token|safe }}')
                 console.log(data)
                 u2f.register(data.appId,data.registerRequests,data.registeredKeys,function (response) {
@@ -21,24 +21,15 @@
                         "url":"{% url 'bind_u2f' %}",method:"POST",
                         data:{"csrfmiddlewaretoken":"{{ csrf_token }}","response":JSON.stringify(response)},
                         success:function (data) {
-                        if (data =='OK')
-                            $("#res").html("<div class='alert alert-success'>Your device is registered successfully, <a href='{{redirect_html}}'> {{reg_success_msg}}</a></div>")
-                        else if (data == "RECOVERY")
+                            if (data == "OK")
                             {
-                            setTimeout(function (){location.href="{% url 'manage_recovery_codes' %}"},2500)
-                            $("#res").html("<div class='alert alert-success'>Your device is registered successfully, but <a href='{% url 'manage_recovery_codes' %}'>redirecting to {{ RECOVERY_METHOD }} method</a></div>")
+                                alert("Your device is added successfully.")
+                                window.location.href="{{ redirect_html }}"
                             }
-                        else
-                            $("#res").html("<div class='alert alert-danger'>Registration failed, please <a href='javascript:void(0)' onclick='addToken()'>try again</a> or <a href='{% url 'mfa_home' %}'> Go to Security Home</a></div>")
-                    },
-                        error: function (data)
-                        {
-                             $("#res").html("<div class='alert alert-danger'>Registration failed, please <a href='javascript:void(0)' onclick='addToken()'>try again</a> or <a href='{% url 'mfa_home' %}'> Go to Security Home</a></div>")
                         }
                     })
                 },5000)
-            }
-    $(document).ready(addToken())
+            })
 
     </script>
 {% endblock %}
@@ -46,11 +37,9 @@
       <br/>
     <br/>
     <div class="container">
-
         <div class="col-md-6 col-md-offset-3" id="two-factor-steps">
-            <div id="res"></div>
             <div class="row" align="center">
-                <h4>Adding {{ method.name}}</h4>
+                <h4>Adding Security Key</h4>
             </div>
     <div class="row">
     <p style="color: green">Your secure Key should be flashing now, please press on button.</p>

mfa/templates/U2F/recheck.html

@@ -4,7 +4,7 @@
 <div class="col-sm-10 col-sm-offset-1 col-xs-12 col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2">
 <div class="panel panel-default card">
       <div class="panel-heading card-header">
-	      <strong> Verify your identity using {{ method.name }}</strong>
+	      <strong> Security Key</strong>
       </div>
       <div class="panel-body card-body">
 

mfa/templates/select_mfa_method.html

@@ -1,10 +1,11 @@
 {% extends "mfa_auth_base.html" %}
 {% block content %}
+    <br/>
 <br/>
 <div class='container'>
 <div class="row">
 
-<div class="col-sm-10 col-sm-offset-1 col-xs-12 col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2 offset-2 col-8">
+<div class="col-sm-10 col-sm-offset-1 col-xs-12 col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2">
 <div class="panel panel-default card">
       <div class="panel-heading card-header">
 	      <strong> Select Second Verification Method</strong>
@@ -14,11 +15,10 @@
               {% for method in request.session.mfa_methods %}
 
               <li><a href="{% url "mfa_goto" method %}">
-                  {% if method == "TOTP" %}{% if 'TOTP' in RENAME_METHODS %}{{ RENAME_METHODS.TOTP }}{% else %}Authenticator App{% endif %}
-                  {% elif method == "Email" %}{% if 'Email' in RENAME_METHODS %}{{ RENAME_METHODS.Email }}{% else %}Send OTP by Email{% endif %}
-                  {% elif method == "U2F" %}{% if 'U2F' in RENAME_METHODS %}{{ RENAME_METHODS.U2F }}{% else %}Secure Key{% endif %}
-                  {% elif method == "FIDO2" %}{% if 'FIDO2' in RENAME_METHODS %}{{ RENAME_METHODS.FIDO2 }}{% else %}FIDO2 Secure Key{% endif %}
-                  {% elif method == "RECOVERY" %}{% if 'RECOVERY' in RENAME_METHODS %}{{ RENAME_METHODS.RECOVERY }}{% else %}Recovery Code{% endif %}
+                  {% if method == "TOTP" %}Authenticator App
+                  {% elif method == "Email" %}Send OTP by Email
+                  {% elif method == "U2F" %}Secure Key
+                  {% elif method == "FIDO2" %}FIDO2 Secure Key
                   {% endif %}
               </a> </li>
               {% endfor %}

mfa/totp.py

@@ -5,14 +5,13 @@ from .Common import get_redirect_url
 from .models import *
 from django.template.context_processors import csrf
 import simplejson
+from django.template.context import RequestContext
 from django.conf import settings
 import pyotp
 from .views import login
 import datetime
 from django.utils import timezone
 import random
-
-
 def verify_login(request,username,token):
     for key in User_Keys.objects.filter(username=username,key_type = "TOTP"):
         totp = pyotp.TOTP(key.properties["secret_key"])
@@ -26,7 +25,7 @@ def recheck(request):
     context = csrf(request)
     context["mode"]="recheck"
     if request.method == "POST":
-        if verify_login(request,request.user.username, token=request.POST["otp"])[0]:
+        if verify_login(request,request.user.username, token=request.POST["otp"]):
             import time
             request.session["mfa"]["rechecked_at"] = time.time()
             return HttpResponse(simplejson.dumps({"recheck": True}), content_type="application/json")
@@ -38,9 +37,6 @@ def recheck(request):
 def auth(request):
     context=csrf(request)
     if request.method=="POST":
-        tokenLength = len(request.POST["otp"])
-        if tokenLength == 6:
-            #TOTO code check
         res=verify_login(request,request.session["base_username"],token = request.POST["otp"])
         if res[0]:
             mfa = {"verified": True, "method": "TOTP","id":res[1]}
@@ -72,19 +68,10 @@ def verify(request):
         #uk.name="Authenticatior #%s"%User_Keys.objects.filter(username=user.username,type="TOTP")
         uk.key_type="TOTP"
         uk.save()
-        if getattr(settings, 'MFA_ENFORCE_RECOVERY_METHOD', False) and not User_Keys.objects.filter(key_type="RECOVERY",
-                                                                                                    username=request.user.username).exists():
-            request.session["mfa_reg"] = {"method": "TOTP",
-                                          "name": getattr(settings, "MFA_RENAME_METHODS", {}).get("TOTP", "TOTP")}
-            return HttpResponse("RECOVERY")
-        else:
         return HttpResponse("Success")
     else: return HttpResponse("Error")
 
 @never_cache
 def start(request):
     """Start Adding Time One Time Password (TOTP)"""
-    context = get_redirect_url()
-    context["RECOVERY_METHOD"] = getattr(settings, "MFA_RENAME_METHODS", {}).get("RECOVERY", "Recovery codes")
-    context["method"] = {"name":getattr(settings,"MFA_RENAME_METHODS",{}).get("TOTP","Authenticator")}
-    return render(request,"TOTP/Add.html",context)
+    return render(request,"TOTP/Add.html",get_redirect_url())

mfa/urls.py

@@ -1,4 +1,4 @@
-from . import views,totp,U2F,TrustedDevice,helpers,FIDO2,Email,recovery
+from . import views,totp,U2F,TrustedDevice,helpers,FIDO2,Email
 #app_name='mfa'
 
 try:
@@ -12,12 +12,6 @@ urlpatterns = [
     url(r'totp/auth', totp.auth, name="totp_auth"),
     url(r'totp/recheck', totp.recheck, name="totp_recheck"),
 
-    url(r'recovery/start', recovery.start, name="manage_recovery_codes"),
-    url(r'recovery/getTokenLeft', recovery.getTokenLeft, name="get_recovery_token_left"),
-    url(r'recovery/genTokens', recovery.genTokens, name="regen_recovery_tokens"),
-    url(r'recovery/auth', recovery.auth, name="recovery_auth"),
-    url(r'recovery/recheck', recovery.recheck, name="recovery_recheck"),
-
     url(r'email/start/', Email.start , name="start_email"),
     url(r'email/auth/', Email.auth , name="email_auth"),
 

mfa/views.py

@@ -1,5 +1,3 @@
-import importlib
-
 from django.shortcuts import render
 from django.http import HttpResponse,HttpResponseRedirect
 from .models import *
@@ -18,16 +16,12 @@ from user_agents import parse
 def index(request):
     keys=[]
     context={"keys":User_Keys.objects.filter(username=request.user.username),"UNALLOWED_AUTHEN_METHODS":settings.MFA_UNALLOWED_METHODS
-             ,"HIDE_DISABLE":getattr(settings,"MFA_HIDE_DISABLE",[]),'RENAME_METHODS':getattr(settings,'MFA_RENAME_METHODS',{})}
+             ,"HIDE_DISABLE":getattr(settings,"MFA_HIDE_DISABLE",[])}
     for k in context["keys"]:
-        k.name = getattr(settings,'MFA_RENAME_METHODS',{}).get(k.key_type,k.key_type)
-        if k.key_type =="Trusted Device":
+        if k.key_type =="Trusted Device" :
             setattr(k,"device",parse(k.properties.get("user_agent","-----")))
         elif k.key_type == "FIDO2":
             setattr(k,"device",k.properties.get("type","----"))
-        elif k.key_type == "RECOVERY":
-            context["recovery"] = k
-            continue
         keys.append(k)
     context["keys"]=keys
     return render(request,"MFA.html",context)
@@ -43,30 +37,22 @@ def verify(request,username):
             return login(request)
         methods.remove("Trusted Device")
     request.session["mfa_methods"] = methods
-
     if len(methods)==1:
         return HttpResponseRedirect(reverse(methods[0].lower()+"_auth"))
-    if getattr(settings,"MFA_ALWAYS_GO_TO_LAST_METHOD",False):
-        keys = keys.exclude(last_used__isnull=True).order_by("last_used")
-        if keys.count()>0:
-            return HttpResponseRedirect(reverse(keys[0].key_type.lower() + "_auth"))
     return show_methods(request)
 
 def show_methods(request):
-    return render(request,"select_mfa_method.html", {'RENAME_METHODS':getattr(settings,'MFA_RENAME_METHODS',{})})
+    return render(request,"select_mfa_method.html", {})
 
 def reset_cookie(request):
     response=HttpResponseRedirect(settings.LOGIN_URL)
     response.delete_cookie("base_username")
     return response
-
-def login(request,username = None):
+def login(request):
     from django.contrib import auth
     from django.conf import settings
     callable_func = __get_callable_function__(settings.MFA_LOGIN_CALLBACK)
-    if not username:
-        username = request.session["base_username"]
-    return callable_func(request,username=username)
+    return callable_func(request,username=request.session["base_username"])
 
 
 @login_required

requirements.txt

@@ -1,4 +1,4 @@
-django >= 2.2
+django >= 2.0
 jsonfield
 simplejson
 pyotp
@@ -6,5 +6,5 @@ python-u2flib-server
 ua-parser
 user-agents
 python-jose
-fido2 == 1.1.0
+fido2 == 0.9.1
 jsonLookup

setup.py

@@ -4,7 +4,7 @@ from setuptools import find_packages, setup
 
 setup(
     name='django-mfa2',
-    version='3.0',
+    version='2.5.2',
     description='Allows user to add 2FA to their accounts',
     long_description=open("README.md").read(),
     long_description_content_type="text/markdown",
@@ -24,7 +24,7 @@ setup(
         'ua-parser',
         'user-agents',
         'python-jose',
-        'fido2 == 1.1.0',
+        'fido2 == 1.0.0',
         'jsonLookup'
       ],
     python_requires=">=3.5",