From ba4e7f9a1755897dc734e1fd711e37011bb9202f Mon Sep 17 00:00:00 2001 From: Tobias Bengfort Date: Thu, 17 Jun 2021 10:35:34 +0200 Subject: [PATCH] lint: fix boolean expressions --- mfa/FIDO2.py | 2 +- mfa/TrustedDevice.py | 2 +- mfa/U2F.py | 6 +++--- mfa/views.py | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/mfa/FIDO2.py b/mfa/FIDO2.py index a595eaa..cb29b2b 100644 --- a/mfa/FIDO2.py +++ b/mfa/FIDO2.py @@ -177,7 +177,7 @@ def authenticate_complete(request): request.session["mfa"] = mfa if not request.user.is_authenticated: res = login(request) - if not "location" in res: + if "location" not in res: return reset_cookie(request) return JsonResponse( {"status": "OK", "redirect": res["location"]} diff --git a/mfa/TrustedDevice.py b/mfa/TrustedDevice.py index 127ee19..c0cc1fd 100644 --- a/mfa/TrustedDevice.py +++ b/mfa/TrustedDevice.py @@ -117,7 +117,7 @@ def start(request): td.save() request.session["td_id"] = td.id try: - if td == None: + if td is None: td = User_Keys.objects.get(id=request.session["td_id"]) context = {"key": td.properties["key"]} except: diff --git a/mfa/U2F.py b/mfa/U2F.py index 627c374..545cbf7 100644 --- a/mfa/U2F.py +++ b/mfa/U2F.py @@ -36,7 +36,7 @@ def recheck(request): def process_recheck(request): x = validate(request, request.user.username) - if x == True: + if x is True: request.session["mfa"]["rechecked_at"] = time.time() return JsonResponse({"recheck": True}) return x @@ -57,7 +57,7 @@ def validate(request, username): data = simplejson.loads(request.POST["response"]) res = check_errors(request, data) - if res != True: + if res is not True: return res challenge = request.session.pop("_u2f_challenge_") @@ -135,7 +135,7 @@ def sign(username): def verify(request): x = validate(request, request.session["base_username"]) - if x == True: + if x is True: return login(request) else: return x diff --git a/mfa/views.py b/mfa/views.py index d9d9fbd..85d3d83 100644 --- a/mfa/views.py +++ b/mfa/views.py @@ -72,7 +72,7 @@ def delKey(request): def __get_callable_function__(func_path): - if not "." in func_path: + if "." not in func_path: raise Exception("class Name should include modulename.classname") parsed_str = func_path.split(".") @@ -90,7 +90,7 @@ def toggleKey(request): q = User_Keys.objects.filter(username=request.user.username, id=id) if q.count() == 1: key = q[0] - if not key.key_type in settings.MFA_HIDE_DISABLE: + if key.key_type not in settings.MFA_HIDE_DISABLE: key.enabled = not key.enabled key.save() return HttpResponse("OK")